redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.85k stars 126 forks source link

Rename two missed usages of Resource.flush_to_disk #377

Closed rbs-jacob closed 11 months ago

rbs-jacob commented 11 months ago

Please describe the changes in your request.

In PR #373, Resource.flush_to_disk was renamed to Resource.flush_data_to_disk. In that rename, I missed a couple of usages of the old flush_to_disk method. This PR fixes those stragglers.

Anyone you think should look at this, specifically?

@whyitfor

whyitfor commented 11 months ago

This looks good.

Should #373 have included a Changed section in the change log flagging the API change for Resource? Since that is the public API I think it should have.

If so, can we roll this changelog update into this PR?