search

redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.82k stars 128 forks source link

Dropping the .altinstr_replacement section from the toolchain #414

Closed rbs-alexr closed 5 months ago

rbs-alexr commented 5 months ago

One sentence summary of this PR (This should go in the CHANGELOG!) We also want to drop the .altinstr_replacement section when we are performing patches

Link to Related Issue(s)

Please describe the changes in your request. This PR adds .altinstr_replacement to the toolchain's linker section droplist

Anyone you think should look at this, specifically? @rbs-afflitto also ran into this issue

rbs-afflitto commented 5 months ago

This looks good to me

whyitfor commented 5 months ago

This needs a Changelog entry for ofrak-patch-maker.

Probably can be considered a bugfix.

whyitfor commented 5 months ago

I'm curious what triggered discovery of this issue. Has it always been around, or is this something new? Did a change create it?

rbs-alexr commented 5 months ago

We observed this section when working on code for AARCH64 Linux 4

rbs-alexr commented 5 months ago

Pending further feedback, can we merge this in?