[X] I have reviewed the OFRAK contributor guide and attest that this pull request is in accordance with it.
One sentence summary of this PR (This should go in the CHANGELOG!)
Fix two tests that fail on occasion for [IMHO] no good reason.
Link to Related Issue(s)
N/A
Please describe the changes in your request.
Two tests would sometime fail for me:
ofrak_core/test_ofrak/components/test_comments.py::test_comment_content had a default 200ms time limit, and once in a while, the limit would be violated (particularly, if other things happen to be running at the same time the tests run) - I have seem numbers as high as 1.6 s on occasion. I bumped the limit to 5s.
ofrak_core/test_ofrak/unit/test_ofrak_context.py::test_get_ofrak_context_over_time would occasionally fail with the RuntimeError: There is no current event loop in thread 'MainThread' error message. I am guessing that would happen when another test executed earlier in the same worker would happen to mess with the asyncio event loop, so I made sure an event loop was available (similar to how the other tests in the same file do it). Not 100% sure this is the right thing, but seems to work.
Anyone you think should look at this, specifically?
Not sure. @whyitfor maybe?
One sentence summary of this PR (This should go in the CHANGELOG!) Fix two tests that fail on occasion for [IMHO] no good reason.
Link to Related Issue(s) N/A
Please describe the changes in your request. Two tests would sometime fail for me:
ofrak_core/test_ofrak/components/test_comments.py::test_comment_contenthad a default 200ms time limit, and once in a while, the limit would be violated (particularly, if other things happen to be running at the same time the tests run) - I have seem numbers as high as 1.6 s on occasion. I bumped the limit to 5s.ofrak_core/test_ofrak/unit/test_ofrak_context.py::test_get_ofrak_context_over_timewould occasionally fail with theRuntimeError: There is no current event loop in thread 'MainThread'error message. I am guessing that would happen when another test executed earlier in the same worker would happen to mess with the asyncio event loop, so I made sure an event loop was available (similar to how the other tests in the same file do it). Not 100% sure this is the right thing, but seems to work.Anyone you think should look at this, specifically? Not sure. @whyitfor maybe?