redballoonsecurity / ofrak

OFRAK: unpack, modify, and repack binaries.
https://ofrak.com
Other
1.82k stars 128 forks source link

Support `make -k test` in docker root #446

Closed ANogin closed 3 months ago

ANogin commented 3 months ago

One sentence summary of this PR (This should go in the CHANGELOG!) Creates an individual target in the root Makefile for each package's make test, with test depending on all of them

Link to Related Issue(s) N/A

Please describe the changes in your request. Creates an individual target in the root Makefile for each package's make test, with test depending on all of them. This has a number of advantages, the biggest (and my motivation) is that this way make -k test in the container root would run through all the packages, rather than stopping on the first one with errors.

Here is an example of the relevant section of Makefile created for ofrak-core-dev.yml with this change:

.PHONY: test test_ofrak_type test_ofrak_io test_ofrak_patch_maker test_ofrak_core test_frontend
test: test_ofrak_type test_ofrak_io test_ofrak_patch_maker test_ofrak_core test_frontend
test_ofrak_type:
        $(MAKE) -C ofrak_type test
test_ofrak_io:
        $(MAKE) -C ofrak_io test
test_ofrak_patch_maker:
        $(MAKE) -C ofrak_patch_maker test
test_ofrak_core:
        $(MAKE) -C ofrak_core test
test_frontend:
        $(MAKE) -C frontend test

Anyone you think should look at this, specifically? Not sure - maybe @whyitfor?

whyitfor commented 3 months ago

@ANogin, looks like you need to run the pre-commit hook against this changeset.

ANogin commented 3 months ago

@ANogin, looks like you need to run the pre-commit hook against this changeset.

Done, not sure why they did not run in the first place, weird...