[x] I have reviewed the OFRAK contributor guide and attest that this pull request is in accordance with it.
One sentence summary of this PR (This should go in the CHANGELOG!)
Explicitly set the Binary Ninja downloaded package file name, so that the installer script knows what to unzip.
Please describe the changes in your request.
The Binary Ninja accepts an --output argument which sets the name of the downloaded Binary Ninja package. This PR uses that argument to set the output file name to binaryninja-headless.zip, so that the script knows what the downloaded .zip is named. This should work across platforms and prevent renaming issues from occurring in the future.
Anyone you think should look at this, specifically?
@whyitfor
One sentence summary of this PR (This should go in the CHANGELOG!) Explicitly set the Binary Ninja downloaded package file name, so that the installer script knows what to unzip.
Link to Related Issue(s) https://github.com/redballoonsecurity/ofrak/issues/450
Please describe the changes in your request. The Binary Ninja accepts an
--outputargument which sets the name of the downloaded Binary Ninja package. This PR uses that argument to set the output file name tobinaryninja-headless.zip, so that the script knows what the downloaded .zip is named. This should work across platforms and prevent renaming issues from occurring in the future.Anyone you think should look at this, specifically? @whyitfor