[x] I have reviewed the OFRAK contributor guide and attest that this pull request is in accordance with it.
One sentence summary of this PR (This should go in the CHANGELOG!)
Do not run Ghidra auto-analysis upon importing a program
Link to Related Issue(s)
N/A
Please describe the changes in your request.
This change adds -noanalysis to the import command in _do_ghidra_import in the GhidraProjectAnalyzer. Without this change, Ghidra analysis runs every time the GhidraProjectAnalyzer runs. This consumes a significant amount of time that is not necessary if using a pre-analyzed Ghidra project. By adding -noanalysis to the import command, the Ghidra analysis will run conditionally in _do_ghidra_analyze_and_serve, depending on if a pre-analyzed Ghidra project has been passed into the analyzer config.
Anyone you think should look at this, specifically?
@whyitfor @SamL98
One sentence summary of this PR (This should go in the CHANGELOG!)
Link to Related Issue(s) N/A
Please describe the changes in your request. This change adds
-noanalysis
to the import command in_do_ghidra_import
in theGhidraProjectAnalyzer
. Without this change, Ghidra analysis runs every time theGhidraProjectAnalyzer
runs. This consumes a significant amount of time that is not necessary if using a pre-analyzed Ghidra project. By adding-noanalysis
to the import command, the Ghidra analysis will run conditionally in_do_ghidra_analyze_and_serve
, depending on if a pre-analyzed Ghidra project has been passed into the analyzer config.Anyone you think should look at this, specifically? @whyitfor @SamL98