redbluegames / unity-text-typer

Text typing effect for Unity uGUI Text components
MIT License
307 stars 28 forks source link

Request: Add an asmdef file #39

Closed kayroice closed 3 years ago

kayroice commented 3 years ago

Hi, can someone build an asmdef for the project? Thanks.

kayroice commented 3 years ago

Here's an asmdef that I built for TextTyper. I left UseGUIDs false so that the asmdef showed the references instead of the references' GUID.

I couldn't get this to work with the Tests directory exposed though, even though I included references to UnityEngine.TestRunner and UnityEditor.TestRunner. Unity complained about not finding the Test and TestAttribute classes. Those classes must be provided by a different asmdef(?). When I hid the Tests directory from Unity this asmdef works as expected.

edwardrowe commented 3 years ago

Thanks for the Issue, and for the sample Assembly definition. It can definitely be inconvenient to use a plugin if it doesn't have these, so I appreciate the reminder.

The issue with the one you were using is that I think you were probably missing the tests-specific Assembly Definition.

To fix this I've added two assembly definitions to the file - one for TextTyper code and the other for the Editor tests specifically.

Let me know if those don't work for you.