Closed redboltz closed 4 weeks ago
Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.
76.00000%
6 lines
Project coverage is 97.31%. Comparing base (5b029eb) to head (58696ff). Report is 3 commits behind head on main.
5b029eb
58696ff
Unified the point of self.complete() call. It fixes other close issue. No regressions are detected #353
self.complete()
Codecov Report
Attention: Patch coverage is
76.00000%
with6 lines
in your changes missing coverage. Please review.Additional details and impacted files
[![Impacted file tree graph](https://app.codecov.io/gh/redboltz/async_mqtt/pull/357/graphs/tree.svg?width=650&height=150&src=pr&token=21ZT59CMM5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Takatoshi+Kondo)](https://app.codecov.io/gh/redboltz/async_mqtt/pull/357?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Takatoshi+Kondo) ```diff @@ Coverage Diff @@ ## main #357 +/- ## ========================================== + Coverage 97.26% 97.31% +0.05% ========================================== Files 153 153 Lines 9474 9469 -5 ========================================== Hits 9215 9215 + Misses 259 254 -5 ``` | [Flag](https://app.codecov.io/gh/redboltz/async_mqtt/pull/357/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Takatoshi+Kondo) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/redboltz/async_mqtt/pull/357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Takatoshi+Kondo) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Takatoshi+Kondo#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/redboltz/async_mqtt/pull/357?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Takatoshi+Kondo) | Coverage Δ | | |---|---|---| | [include/async\_mqtt/impl/endpoint\_close.hpp](https://app.codecov.io/gh/redboltz/async_mqtt/pull/357?src=pr&el=tree&filepath=include%2Fasync_mqtt%2Fimpl%2Fendpoint_close.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Takatoshi+Kondo#diff-aW5jbHVkZS9hc3luY19tcXR0L2ltcGwvZW5kcG9pbnRfY2xvc2UuaHBw) | `98.48% <100.00%> (ø)` | | | [...nclude/async\_mqtt/util/impl/stream\_read\_packet.hpp](https://app.codecov.io/gh/redboltz/async_mqtt/pull/357?src=pr&el=tree&filepath=include%2Fasync_mqtt%2Futil%2Fimpl%2Fstream_read_packet.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Takatoshi+Kondo#diff-aW5jbHVkZS9hc3luY19tcXR0L3V0aWwvaW1wbC9zdHJlYW1fcmVhZF9wYWNrZXQuaHBw) | `98.55% <100.00%> (+<0.01%)` | :arrow_up: | | [...clude/async\_mqtt/util/impl/stream\_write\_packet.hpp](https://app.codecov.io/gh/redboltz/async_mqtt/pull/357?src=pr&el=tree&filepath=include%2Fasync_mqtt%2Futil%2Fimpl%2Fstream_write_packet.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Takatoshi+Kondo#diff-aW5jbHVkZS9hc3luY19tcXR0L3V0aWwvaW1wbC9zdHJlYW1fd3JpdGVfcGFja2V0LmhwcA==) | `97.19% <100.00%> (+0.02%)` | :arrow_up: | | [include/async\_mqtt/util/ioc\_queue.hpp](https://app.codecov.io/gh/redboltz/async_mqtt/pull/357?src=pr&el=tree&filepath=include%2Fasync_mqtt%2Futil%2Fioc_queue.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Takatoshi+Kondo#diff-aW5jbHVkZS9hc3luY19tcXR0L3V0aWwvaW9jX3F1ZXVlLmhwcA==) | `100.00% <100.00%> (ø)` | | | [...nc\_mqtt/predefined\_layer/customized\_ssl\_stream.hpp](https://app.codecov.io/gh/redboltz/async_mqtt/pull/357?src=pr&el=tree&filepath=include%2Fasync_mqtt%2Fpredefined_layer%2Fcustomized_ssl_stream.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Takatoshi+Kondo#diff-aW5jbHVkZS9hc3luY19tcXR0L3ByZWRlZmluZWRfbGF5ZXIvY3VzdG9taXplZF9zc2xfc3RyZWFtLmhwcA==) | `82.35% <70.00%> (+7.93%)` | :arrow_up: |