search

redbooth / npm-shrinkwrap-check

Util to check that package.json and npm-shrinkwrap.json are in sync.
14 stars 7 forks source link

Ignore package.json files outside package roots #9

Closed gjvis closed 8 years ago

gjvis commented 8 years ago

This prevents false negatives arising from package.json files that are nested inside dependencies for whatever reason.

For example, the asn1.js package includes two nested package.json files (here and here), which end up incorrectly being used as sources of dependencies for packageDeps.

Morantron commented 8 years ago

Nice!

I'll check with some known fail cases. This should solve this two open issues right now: https://github.com/teambox/npm-shrinkwrap-check/issues/8 https://github.com/teambox/npm-shrinkwrap-check/issues/6

Thanks!

gjvis commented 8 years ago

No problem :)

Morantron commented 8 years ago

Cool, seems to work! Merging it :ok_hand: