search

redbox-mint / redbox

http://www.redboxresearchdata.com.au
GNU General Public License v2.0
5 stars 10 forks source link

<dd> tags not closed in plans and self-submission forms #39

Open grantj-re3 opened 11 years ago

grantj-re3 commented 11 years ago

For ReDBox dev-local 1.6.1: If you navigate to viewing a plan (Details screen) at http://MYSERVER/redbox/dashboard/detail/OID or viewing a draft (ie. not yet submitted) self-submission dataset (Details screen) at a similar URL you will notice in the source html that many <dd> tags do not have a closing </dd> tag.

Some example fixes are given below for "displayPerson" & "display" velocity macros (where the first argument to the diff command is the fixed file).

Data Management Plan:

cd portal/dashboard/dashboard/display/package-dmpt/detail/preview/sections
diff people.vm people.vm.dev_local_1.6.1
25d24
<     #end
26a26
>     #end

Selfsub dataset:

cd portal/dashboard/dashboard/display/package-self-submission/detail/preview/sections
diff people.vm people.vm.dev_local_1.6.1
24d23
<     #end
25a25
>     #end

cd portal/dashboard/dashboard/display/package-self-submission/detail/preview
diff body.vm body.vm.dev_local_1.6.1
15d14
<     #end
16a16
>     #end
grantj-re3 commented 8 years ago

These syntax issues remain in ReDBox v1.8.

At the following 3 lines (associated with the 3 files above) the closing tag </dd> should be below the #if block (ie. immediately before the end of the macro definition).