redboxllc / scuttle

A wrapper for applications to help with running Istio Sidecars
MIT License
116 stars 25 forks source link

Add timestamps to scuttle logging #23

Closed linjmeyer closed 4 years ago

linjmeyer commented 4 years ago

When something goes wrong with scuttle, Istio or the underlying executable being run you can get logs like:

scuttle: Logging is now enabled
scuttle: Blocking until envoy starts
scuttle: Blocking finished, envoy has started
scuttle: Received exit signal, exiting

Timestamps would help understand what happened with logs like this. In the above it's not possible to determine if scuttle was hung, for how long it ran, etc.

Scuttle doesn't use a real logging package/framework right now, it may be better long term to investigate what logging options exist in the go ecosystem.