redboxllc / scuttle

A wrapper for applications to help with running Istio Sidecars
MIT License
116 stars 25 forks source link

Fixing panic on WAIT_FOR_ENVOY_TIMEOUT #38

Closed linjmeyer closed 4 years ago

linjmeyer commented 4 years ago

By default Scuttle waits forever for Envoy to start, you can set WAIT_FOR_ENVOY_TIMEOUT (#22) to tell Scuttle to start the application without Istio/Envoy after a certain amount of time. I tried this today and Scuttle still throws a panic when the timeout is reached.

This PR changes the panic to a log line, then allows the application to start after WAIT_FOR_ENVOY_TIMEOUT time has been reached. Default functionality of waiting indefinitely is not changed.