search

redbrick / TechWeek

Event Page for techweek
http://techweek.dcu.ie
MIT License
2 stars 8 forks source link

move build scripts to npm package #96

Closed butlerx closed 7 years ago

VoyTechnology commented 7 years ago
  1. What is the rationale behinds moving it to npm package? I can't really see much benefit right now with this change
  2. I've noticed the schema is missing. Does that mean we are no longer checking the pages or am I missing something?

I was personally thinking that converting the page to use Polymer would benefit the site more. What do you think?

VoyTechnology commented 7 years ago

+CC @benmcmahon100

butlerx commented 7 years ago

polymer would be over kill for techweek, the idea of separating it it out is so move all the code todo with generating out of this repo so this one is just front end. the schema is not the default schema in the npm package and can be replaced if specified in a config

VoyTechnology commented 7 years ago

I would disagree that its an overkill. If it had a huge boilerplate associated with it, then yes. While I don't have much experience with Polymer, it seems like the benefits of highly modular code outweigh the disadvantages associated with bringing in a whole framework. Let's just leave the decision to the current webmaster because we can "fight" all day :)

butlerx commented 7 years ago

techweek doesn't need modules though, its a statically generated site with jquery only for materilizecss