redbrick / static-site

Statically generated site for Redbrick
https://redbrick.dcu.ie
GNU General Public License v3.0
15 stars 21 forks source link

replace node server with caddy and hexo with hugo #314

Open butlerx opened 6 years ago

butlerx commented 6 years ago

Closes #

Description

Remove node app. None of these features are used and add complexity so should be removed

Checklist

I confirm that before I submitted this pull request I did the following:

m1cr0man commented 6 years ago

Will the circleci test start passing after this is merged or is it very broken?

theycallmemac commented 6 years ago

Conflicts with some commits I made a few hours ago, once he has those files, it should be passing ci again and good to merge.

butlerx commented 6 years ago

while chatting too @m1cr0man offline he mentioned a possible rewrite id like to suggest using hugo and using https://caddyserver.com/docs/http.hugo

this will have to manually deployed now by one of the @admins

theycallmemac commented 6 years ago

We talked about the idea last Thursday with @Frazl

A hugo replacement would be very nice. Probably not as extendable as hexo is, but then again, we only use some of the existing extensions.

butlerx commented 6 years ago

I think you'll find that a lot of the extensions that are used in hugo can be taken care of by some nice templates in hugo.

Using caddy you can also get a lot of the minification advantages you got in hexo

butlerx commented 6 years ago

a hugo rewite would also mean sistem, redbrick and admin-blog would all be the same platform

m1cr0man commented 6 years ago

Hm, that last one is a pretty compelling argument.

I will look into what we can do with Hugo then, and how the other 2 sites are currently set up/what differs between them (if anything).

My main concern with these templating engines is that once you want to deviate from the template it gets more complex than it is worth.

butlerx commented 6 years ago

this convo may want to be moved to an issue. I think sistem has a bit of a unique set up as it uses scss and es6 for client stuff but the templating and md rendering is all hugo.

admin-blog is just plain css and no js

ping me with any questions

theycallmemac commented 6 years ago

Yeah, all three being one and the same would be nice. Best move it to issue for now like you say

butlerx commented 6 years ago

tests are now passing, when an admin is available to deploy the new container and very its all working you can merge

it should be noted the reason tests were not working was one of the dependency upgrades I tried mangled the use of <!-- more --> so I reverted all dependencies

butlerx commented 6 years ago

closes #30 #114 #183 #194 #77 #48

butlerx commented 5 years ago

@m1cr0man @theycallmemac updated with hugo

m1cr0man commented 5 years ago

I will review this too James so please don't merge if you beat me to it

benmcmahon100 commented 5 years ago

@m1cr0man Did you get to take a look or will I? @theycallmemac If you got to have a look feel free to leave a review

m1cr0man commented 5 years ago

Ah, yes I will review at lunch time

theycallmemac commented 5 years ago

@butlerx will review this evening when I finished off some college work.

butlerx commented 4 years ago

circle is broken, think the keys expired