search

redbrick / useradm

useradm and Redbrick registration system
The Unlicense
4 stars 6 forks source link

Linting Python Files #24

Closed gruunday closed 7 years ago

butlerx commented 7 years ago

please merge in origin master

butlerx commented 7 years ago

we use 100 char line length not 80

gruunday commented 7 years ago

Why not stick with pep8

butlerx commented 7 years ago

because we are using codeclimate for linting "codeclimate — no new or fixed issues"

butlerx commented 7 years ago

it matters because codeclimate enforces our linting on pr. its what people will use to check they follow the style guide

gruunday commented 7 years ago

Yes but why is pep8 not our style guide

butlerx commented 7 years ago

because we decided to use pylint and thats what sre intergrations are configured to check for

gruunday commented 7 years ago

We? Why? Pros, Cons?

butlerx commented 7 years ago

i dont remember the pros and cons anymore :stuck_out_tongue: im forgetful. it was discussed and agreed upon

gruunday commented 7 years ago

But who. I want to know what the majority of people on this project think is the best style guide to follow?

CSmartt commented 7 years ago

Anyone got a log of this discussion/agreement? Might clear this up and save us all having to read this back&forth.

butlerx commented 7 years ago

i didnt keep a list :P i know @VoyTechnology and @GoldenBadger were part of the discussion

gruunday commented 7 years ago

Does pylint not implement pep8 as default?

GoldenBadger commented 7 years ago

According to their website it does.

On Thu, 1 Jun 2017, 8:14 p.m. Tom Doyle, notifications@github.com wrote:

Does pylint not implement pep8 as default?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/redbrick/useradm/pull/24#issuecomment-305592345, or mute the thread https://github.com/notifications/unsubscribe-auth/AC9-QFazt9gRHC4XYG6QCsgu7rYyfvC2ks5r_w2fgaJpZM4NtFFK .

butlerx commented 7 years ago

:man_shrugging: all i know is its had us writing for 100 char

butlerx commented 7 years ago

https://gist.github.com/butlerx/a7cc82ccb5b40a4e3d02c87c26769a58#file-pylint-txt-L11 this is from default pylint

gruunday commented 7 years ago

Okay this seems to be the biggest difference. We will continue with pylint until such time that we find it does not suit us.