Closed AlbertoPellitteri closed 1 month ago
Hello @AlbertoPellitteri - Can you perhaps share a screenshot of execution and clean up! Thank you :)
Hey @patel-bhavin! Sure thing! Here are some screenshots for the first test (Docker). It should be the same for the second test as well (Podman).
I first want to show you how the test looks like right now. As you can see the docker build command fails because of the wrong LABEL syntax in the Dockerfile.
Here are the results of the execution right after the fix on the Dockerfile's label and running the test again. In this case, the test was executed successfully. However, even though the cleanup stops the container, it remains there, without being deleted. Moreover the docker image is not deleted as expected as printed out by the message error: Error response from daemon: No such image: t1613_container:latest
.
Applying all the fixes together (Dockerfile label, adding -rm
to docker run, and fixing the docker rmi
command), you can see how the whole test is successfully executed: the container is running as expected and then it gets stopped and deleted with its related image launching the Cleanup
command.
@AlbertoPellitteri : amazing! thank you for the detailed explanation with the screenshots!
Details: This PR should fix some issues for test T1613-1 and T1613-2:
name=value
format.--rm
option in thedocker run
command to make sure its resources are deleted and that running this test multiple times does not fail because of "container name already in use" error. The other viable option is to add thedocker rm command
in the cleanup phase right after the container is stopped. Let me know if you have a strong opinion on this.docker rmi
command failed because the docker image ist1613
and nott1613_container
, which is instead the container name.Testing: Tested on Ubuntu 20.04