redcolorbicycle / pe

0 stars 0 forks source link

Names do not allow dashes #6

Open redcolorbicycle opened 2 months ago

redcolorbicycle commented 2 months ago

Screenshot (160).png

Currently, there are real life examples of people with dashes in their name. Attached is a picture of an example: Lim Zinn-E, with a dash in his name, is a real life student who studied in Singapore and is currently in Harvard. The app currently does not allow people with names similarly structured to his to be POC.

nus-se-bot commented 2 months ago

Team's Response

image.png We have already included this under planned enhancements. This is similar to 's/o' raised in Issue 3405 which is also mentioned in planned enhancements.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Disallows the use of s/o in an individual's name

Screenshot 2024-04-19 at 5.01.37 PM.png

As shown in the image above, when s/o is in used in the name of poc, ( /poc jane s/o yeo ), the application disallows the adding of the internship.

Screenshot 2024-04-19 at 5.01.48 PM.png

Disallowing s/o in a person name because / is used as a command delimiter can cause a major problem if the input is expected to match the legal name of the person. The team can also considering allowing the use of / in an individual's name.


[original: nus-cs2103-AY2324S2/pe-interim#4293] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is under planned enhancements.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]