redcross / smoke-alarm-portal

Red Cross web portal accepting free smoke alarm installation requests
https://getasmokealarm.org/
Other
7 stars 20 forks source link

For SMS requests, show raw address string in email and admin portal #156

Open cecilia-donnelly opened 8 years ago

cecilia-donnelly commented 8 years ago

The address parser works imperfectly, and humans are better at understanding the raw address strings than computers are. Let's show the raw strings in the email and the admin portal, for SMS requests. We'll still use the parser to find the zip code and try to get the city and state, but this way the humans will be able to see the original string, in case parsing fails.

cecilia-donnelly commented 8 years ago

@kfogel points out that really what we need is:

  1. a better parsing library, that fails less often
  2. a conditional check on the parsed object. If the parser successfully found city and state, then show the parsed version of those things. If not, show the raw string with a message to the admin / installer that says "We couldn't parse this, but the request says <this>" or similar.