search

redcross / smoke-alarm-portal

Red Cross web portal accepting free smoke alarm installation requests
https://getasmokealarm.org/
Other
7 stars 20 forks source link

Combine the Eastern (EAMO) and Western Missouri (WEMO) Regions and the newly added Arkansas Region into a single region (MOAK) #276

Open jim-mcgowan opened 5 years ago

jim-mcgowan commented 5 years ago

Note that the new MOAK region includes nine Illinois and six Kansas counties and excludes two Arkansas and four Missouri counties. See the attached spreadsheet and regional map. MO-AK getasmokealarm Counties.xlsx RCMOAR_REG.pdf

kfogel commented 5 years ago

Look at issue #277 when looking at this. It probably makes sense to do the #277 schema changes first, so that when we combine EAMO, WEMO, and Arkansas to make the new MOAK region, the county/chapter data for MOAK is already there (and for every other region, it will be empty for now, but at least there will be a slot for that data when we get the data).

kfogel commented 5 years ago

Hey, @OhMcGoo: in the spreadsheet, some of the rows have overstrikes across them. Of the overstruck rows, some of them are in IL, rather than in MO or AK. There are also some non-overstruck rows that have IL, but I see you have noted that those are expected -- thank you. So the question is: how to treat the overstruck rows?

jim-mcgowan commented 5 years ago

See my comment above regarding the county makeup of the Region. Look, also, at the map. Here is a revised spreadsheet with the 'strikethrough counties' removed. MO-AK getasmokealarm Counties.xlsx

frankduncan commented 5 years ago

@OhMcGoo @kfogel Do we want to go back through old requests that may have been in zip codes not previously handled that are part of this new region and assign them here?

frankduncan commented 5 years ago

As part of this issue, we're going to do all counties, chapters, and regions in the spreadsheet linked in this comment: https://github.com/redcross/smoke-alarm-portal/issues/277#issuecomment-466219685

jim-mcgowan commented 5 years ago

@frankduncan, @kfogel: I don't think we should try to reassign requests. I think it will confuse the regions. But we will need to notify them when to expect new requests from counties that were not previously a part of the application (Arkansas).

frankduncan commented 5 years ago

@OhMcGoo For previous requests that were part of WEMO and EAMO, should we assign those to MOAK, or keep WEMO and EAMO regions around for archival purposes?

jim-mcgowan commented 5 years ago

@frankduncan: Let's combine all past EAMO and WEMO requests under MOAK but I would suggest consulting with @kfogel about how to handle the request IDs (as they contain the strings EAMO and WEMO).

frankduncan commented 5 years ago

@OhMcGoo @kfogel I believe we should keep the IDs the same, because they may have been recorded by the requester to be referenced in future conversation.

kfogel commented 5 years ago

@frankduncan I'm okay with that if @OhMcGoo is. The more I think about it, the more sane it seems.

Do we want to keep having the region code as part of the ID? I don't really know in practice how useful it is -- it depends who's discussing requests and using the request IDs as handles in those conversations. My under-informed guess is that it is useful to have the region code in there and that we should keep it, but @OhMcGoo if you have any user-side knowledge to impart, please do.

jim-mcgowan commented 5 years ago

@kfogel, @frankduncan: I'm pro-sanity.

kfogel commented 5 years ago

It's a controversial position, but I'm glad you're sticking to your principles.

frankduncan commented 5 years ago

@OhMcGoo Consolidating all the comments here:

jim-mcgowan commented 5 years ago

@OhMcGoo Consolidating all the comments here:

  • I noticed in this spreadsheet that there are many region codes for the Dakota. Wanted to check that that makes sense.

The Region Code was correct; there were several Chapter Codes for the Eastern North Dakota and Northwest Minnesota Chapter (34118). This has been resolved in the attached spreadsheet. Note: Use the All tab. getasmokealarm Counties.xlsx

  • There's some small descrepencies between names. For instance, in our database it's "Northwest Region", but in the spreadsheet it's "Northwest" Do you want me to bring our DB in line with what you have, or leave it as is?

No region should have "Region" in its name. Thus, Northwest.

  • The only non Arkansas county that wasn't already in our database is from Shannon, South Dakota. So that will get added too.

Shannon, SD is in the Central and Western South Dakota Chapter (Dakotas Region). Shannon, MO is in the Southeast Missouri Chapter (Missouri and Arkansas Region). Both appear in the spreadsheet. There is no Shannon County in Arkansas. I've attached the all the region maps for reference. Region Maps.zip

  • The counties that are crossed out in the spreadsheet are in our database, should we remove them?

There are no struckthrough counties in the data. See the spreadsheet, attached.

frankduncan commented 5 years ago

Thanks @OhMcGoo ! And it seems the issue is actually with my spreadsheet program adding a lot of strike throughs that aren't actually there (?). When I load it up in Excel, it's much better.

jim-mcgowan commented 5 years ago

See my comments in the attached PDF. MOAK Comments.pdf

jim-mcgowan commented 5 years ago

@frankduncan: The availability language is missing a "T" at the beginning of the first sentence. Can you put it back in?

missing t

Thanks!

frankduncan commented 5 years ago

Oh ack! Fixed!

Thanks for the catch

Frank

On Mon, Mar 4, 2019 at 12:07 PM Jim McGowan notifications@github.com wrote:

@frankduncan https://github.com/frankduncan: The availability language is missing a "T" at the beginning of the first sentence. Can you put it back in? [image: missing t] https://user-images.githubusercontent.com/4147733/53753070-eeccb680-3e75-11e9-9229-5c76db679be5.png

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/redcross/smoke-alarm-portal/issues/276#issuecomment-469355012, or mute the thread https://github.com/notifications/unsubscribe-auth/AE40xHIBIeSLJCaTsxFmdCz80eskFBn_ks5vTWDWgaJpZM4bDr22 .