search

reddcoin-project / reddcoin-3.10

Reddcoin: the digital social currency
http://www.reddcoin.com
MIT License
287 stars 114 forks source link

Update rpcrawtransaction.cpp #88

Closed Sjolus closed 7 years ago

Sjolus commented 7 years ago

Adjust for libboost 1.58

Same commit as https://github.com/bitcoin/bitcoin/pull/6114/commits/824c011d165cc352088f8e238f66b829b0e654ed and referred to in mother repo litecoin here https://github.com/litecoin-project/litecoin/issues/243 (same fix for the issue)

reddink commented 7 years ago

Thanks @Sjolus I was only reading this on Feathercoin forum yesterday in regards to similar compile error. I had been testing and building with 1.54 locally and with 1.55 using gitian build (these are the minimum versions).

Taking a look at feathercoin implementation (below), they created a conditional, but after testing with boost 1.54 it does compile and run successfully with your change

feathercoin

warning BOOST_VERSION

#if ((BOOST_VERSION / 100000 == 1) && (BOOST_VERSION / 100 % 1000 == 58))
        const CScriptID& hash = boost::get<const CScriptID>(address);
#else
         const CScriptID& hash = boost::get<const CScriptID&>(address);
#endif
        CScript redeemScript;