Update Litecoin

[oritwoen]

This project is a fork Litecoin but I see that it is not the current version. Among other things, the following error has been corrected in Litecoin (appears when compiling):

https://github.com/litecoin-project/litecoin/commit/2ede6b7142cb57c422126722f845b36da7d3c4ef

In file included from net.cpp: 24: 0:
/usr/include/miniupnpc/miniupnpc.h:62:1: note: DECLARED here

I will be grateful for updated fork or patch so that the compilation work correctly :)

[reddink]

The current release is now a fork of Bitcoin, Unfortunately, one is not able to update the github details to reflect that :)

The current build was tested using miniupnpc 1.6 (original)

To resolve the error looks like a trivial fix.

Let me take a look

[reddink]

I have just pushed the following commit (81b71123e94ec06c5733cc25c2bb5c9624113259) onto master branch (which also contains a few extra fixes)

[oritwoen]

This error no longer displays but now appear other: x Screenshot terminal attached.

[reddink]

This is an issue with the newer versions of boost and compiling with c++11 Referencing against the issue on bitcoin. https://github.com/bitcoin/bitcoin/commit/a2b04ddfe6452e7d6274f4096bf3f2aee695a6d9

I can patch this in tonight,

[reddink]

I have pushed this update to my personal Reddcoin repo first. https://github.com/reddink/reddcoin Can you test it against your system?

[oritwoen]

It works a little better but still in one place, now a little later, there are problems with the make.

System: Fedora 25

[reddink]

What is the error now reported?

[oritwoen]

./autogen.sh

make

[reddink]

Thanks for that. The first screen is ok.. these warnings are expected

Second screen, The warning is triggered in the version of boost you have installed (1.61?) https://github.com/libbitcoin/libbitcoin/issues/582

It is a known issue and should be resolved in boost 1.62

These should be warnings only, there must be an error also in the output

[oritwoen]

You're right, there is a fault. Nothing else appears.

[reddink]

Ok, compiling with QT5 support. The error relates to QT5 build hardening can you run configure with the following CXXFLAGS="-fPIC" ./configure CXXFLAGS="-fPIC"

in the current Reddcoin configure, it is using -fPIE as default. I will need to pull the updated configure scripts from bitcoin to pull into our build

[oritwoen]

Hmm, I checked this. Not work. I used ./configure CXXFLAGS="-fPIC". Makefile contains fPIC instead fPIE but error is the same.

[reddink]

Ok.. thanks for testing. I have found the relevant commits on bitcoin.. They will need a bit of work to pull into Reddcoin.. stand-by

[reddink]

Pulling the relevant build updates is going to take longer than expected. Can you try running: make clean ./configure CXXFLAGS="-fPIC" CFLAGS="-fPIC" make

[oritwoen]

Clean git repository https://github.com/reddink/reddcoin and ./configure CXXFLAGS="-fPIC" CFLAGS="-fPIC" the error this same.

No hurry about it. Take care of more important matters, and to find the time to come back to this, I prefer to compile own wallets but currently I use the downloaded binaries for Linux so it's okay.

[oritwoen]

Problem solved.

./configure CXXFLAGS="-fPIC" CFLAGS="-fPIC" – add fPIC on root folder Makefile but not change ./src/qt/Makefile.

I edited ./src/qt/Makefile CXXFLAGS and manually change fPIE to fPIC.

Btw, please update official branch with previous commit: https://github.com/reddink/reddcoin/commit/2ab654109b69a69c1f4197d4727011afab7d7440

And maybe update ./configure to work with all makefiles not only root?

[reddink]

Thanks, glad you got it working. Will make these changes

[davidmar0003]

Thanks I hope I can get this to work. If not I'll be back.

[Sylk]

This ticket should be closed.