search

redddcyclone / glpi-agentmonitor

GLPI-Agent monitoring utility for Windows (systray icon)
GNU General Public License v2.0
9 stars 5 forks source link

Update GLPI-AgentMonitor.rc #5

Closed kintaro1981 closed 1 year ago

kintaro1981 commented 1 year ago

added italian translation

I tried with visual studio 2022 but it gave me a problem during .exe creation, it was detected as a virus: Gen:Variant.Tedy.375120 from BitDefender.

Can you check if is all ok?

redddcyclone commented 1 year ago

Hi @kintaro1981

First of all, thanks for the contribution!

About BitDefender, it is a false positive. Please try compiling for x64 when testing, or if the same happens, put an exclusion in the antivirus.

About the translation, mostly everything is good, but could you see if it's possible to make the change I requested above? Thanks!

kintaro1981 commented 1 year ago

This string above is too big for the button. Is it possible to trim it down?

Yes

About BitDefender, it is a false positive. Please try compiling for x64 when testing, or if the same happens, put an exclusion in the antivirus.

About the translation, mostly everything is good, but could you see if it's possible to make the change I requested above? Thanks!

I finally compiled it successfully. how I change the pull request with the GLPI-AgentMonitor.rc updated and fixed? I need to do modify it in my repository and then do another pull request?

kintaro1981 commented 1 year ago

Maybe I done it. I changed the file in my repo and saved in the same branch (sorry but I'm a newbie of git)

redddcyclone commented 1 year ago

Just commit the updated file. Every commit you do to the branch you want to merge in my repository will be automatically referenced.