search

redding / assert

Assertion style testing framework.
https://github.com/redding/assert
MIT License
10 stars 1 forks source link

use a config/init pattern #106

Closed kellyredding closed 11 years ago

kellyredding commented 11 years ago

This reworks all the Assert configuration to follow a config/init pattern. This allows for a clear precedence for specifying and overriding settings. Settings are applied in 4 scopes in this order: User, Local, CLI, ENV.

This enables two new features: loading Local settings from a relative ~/.assert.rb file and overriding settings using the CLI. Both of those features will come after this new pattern is in place.

@jcredding this is a WIP. Would you mind reading over the new README and make sure everything makes sense? This is essentially my requirements doc for the config/init pattern updates. Thanks man.

jcredding commented 11 years ago

@kellyredding - README looks good. The hierarchy is clear and smart. I don't see any problems with the way you've laid everything out.

kellyredding commented 11 years ago

@jcredding Ok, this is ready for review now. I think this has all the config/init pattern stuff in place and all the tests pass and it does what its supposed to. Still in v2.0 effort:

jcredding commented 11 years ago

@kellyredding - This looks good. Very clear with how the settings are applied. :boom: