redding / assert

Assertion style testing framework.
https://github.com/redding/assert
MIT License
10 stars 1 forks source link

rework suite implementation/handling; add DefaultSuite #235

Closed kellyredding closed 9 years ago

kellyredding commented 9 years ago

This reworks the suite object to make it more flexible to extend. This follows the pattern of the view object where the base suite provides the core logic/behavior and the default suite provides the default assert behavior. The goal here is to enable extending the suite for use in AssertSqlite (and Parassert).

The suite is responsible for accumulating tests for the runner to run and for providing the run data and test result data. The default suite stores run data and results in memory.

Note: this begins the work of formalizing the test/result data api. In a coming effort, I'll rework the default view to fully use this api and implement the full api in the default suite.

There are a few other smaller changes here:

@jcredding ready for review.

jcredding commented 9 years ago

@kellyredding - Just one question about a few methods that didn't get overridden in the DefaultSuite. Otherwise I'm good with this :boom:

kellyredding commented 9 years ago

@jcredding I'm going to go ahead and merge since your comment will be addressed in a coming effort.