search

redding / assert

Assertion style testing framework.
https://github.com/redding/assert
MIT License
10 stars 1 forks source link

include one-time suite setups/teardowns in total test run time #246

Closed kellyredding closed 8 years ago

kellyredding commented 8 years ago

Not including it has been around since the beginning (see e4a019a). I don't see a good reason to not include it though. We include the setup/teardown of each test. Plus not including it makes the reported test suite run times shorter than the actual perceived run time.

I say let's include the in the total run time so it is more honest and better matches perceived run times.

@jcredding ready for review. You OK with this man? Any concerns I'm missing in changing this?

jcredding commented 8 years ago

@kellyredding - I'm good with moving them into the total time. Like you say its more honest about the actual test time. Good stuff :boom: