search

redding / assert

Assertion style testing framework.
https://github.com/redding/assert
MIT License
10 stars 1 forks source link

accumulate: properly sort result data by the file name and line num #271

Closed kellyredding closed 8 years ago

kellyredding commented 8 years ago

Previously, the data just stored the file_line string which did not sort the file line number portion as intended b/c string integers don't sort like integers. This switches the storing the file name and line number of the result independently and using those to properly sort the results by reverse definition order.

This edge case was missed in PR 269 but was missed. This is part of the effort to accumulate test run data instead of storing test objects.

See #269 for reference.

@jcredding ready for review.

jcredding commented 8 years ago

@kellyredding - You have "lin num" in your PR title instead of "line num"

jcredding commented 8 years ago

@kellyredding - Looks good :boom: