assert helpers args not consistant??

redding / assert

Assertion style testing framework.

https://github.com/redding/assert

MIT License

10 stars 1 forks source link

assert helpers args not consistant?? #30

Closed kellyredding closed 13 years ago

kellyredding commented 13 years ago

let's discuss this. I think we should be consistant here and have args be passed to helpers in similar ways. For example, assert_equal is assert_equal <expectedval>, <testval>. However assert_respond_to is assert_respond_to <testobj>, <expected>. Let's chat on monday.

jcredding commented 13 years ago

Others to consider:

assert_includes <collection>, <instance>
assert_kind_of <class>, <instance>
assert_instance_of <class>, <instance>

kellyredding commented 13 years ago

taking this one - will most likely change them to be expected, actual format consistently. FYI. Complain if needed.

kellyredding commented 13 years ago

done: https://github.com/teaminsight/assert/commit/77263d0d1de9a7ce1735def0c629c952adfe48d8