redding / assert

Assertion style testing framework.
https://github.com/redding/assert
MIT License
10 stars 1 forks source link

Views: view callbacks and custom view handling #90

Closed kellyredding closed 12 years ago

kellyredding commented 12 years ago

This overhauls the view setup for assert. There are two big changes here:

kellyredding commented 12 years ago

@jcredding - look over it and weigh in on pros/cons. I'm going to break up assert-view and see how nicely this works in practice. Anyway.

jcredding commented 12 years ago

@kellyredding - one quick note, are you using rdoc or markdown for your README? It's a .rdoc file, but this assert view section looks like it's supposed to be markdown? You can see it not formatting some stuff here:

https://github.com/kellyredding/assert/tree/view

kellyredding commented 12 years ago

@jcredding - Its using rdoc right now, but I have become so accustomed to writing markdown that I keep adding it in. I'll have a follow up pull request where I convert the readme to markdown.

SOON...

(thanks for the detailed review, btw)

kellyredding commented 12 years ago

Rebased and re-pushed the commits. Ready to merge. @jcredding - any problems with a me merging this in?