reddit / baseplate.go

Reddit's Service Framework in Go
https://pkg.go.dev/github.com/reddit/baseplate.go
BSD 3-Clause "New" or "Revised" License
92 stars 77 forks source link

Add config for the header use by the general ingress #638

Closed nanassito closed 9 months ago

nanassito commented 10 months ago

๐Ÿ’ธ TL;DR

We now have a generic ingress for thrift traffic that routes the traffic based on a header. This means that looking at a service config we don't see what service the traffic is going to and that the application need to set the header manually unlike every other configuration bit.

So this PR adds a new configuration to set this header.

๐Ÿ“œ Details

[Design Doc]()

[Jira]()

๐Ÿงช Testing Steps / Validation

โœ… Checks

nanassito commented 10 months ago

Ideally I'd like to add tests but I'm not sure how. I haven't found a way to check the headers yet.