search

reddit / baseplate.go

Reddit's Service Framework in Go
https://pkg.go.dev/github.com/reddit/baseplate.go
BSD 3-Clause "New" or "Revised" License
90 stars 76 forks source link

Add omitempty yaml tag to deprecated log.Wrapper fields #658

Closed fishy closed 1 month ago

fishy commented 1 month ago

Also implement log.Wrapper.MarshalYAML for nil values.

Also add yaml:"-" explicitly for config struct fields that's not yaml-unmarshal-able.

fishy commented 1 month ago

(Also note that this bumps the minimum version for baseplate.go in the release notes)

I just included https://github.com/reddit/baseplate.go/pull/659, as otherwise the CI would not run.

fishy commented 1 month ago

Update PR description?

I think the current PR description covered everything that's not in https://github.com/reddit/baseplate.go/pull/659? Do you notice anything missing?