Support attributing client metrics back to the owning cluster - Githubissues

reddit / baseplate.go

Reddit's Service Framework in Go

https://pkg.go.dev/github.com/reddit/baseplate.go

BSD 3-Clause "New" or "Revised" License

92 stars 77 forks source link

Support attributing client metrics back to the owning cluster #661

Closed justinmir closed 1 month ago

justinmir commented 1 month ago

💸 TL;DR

This adds a new cluster label to client metrics. This can be used to join the client metrics with the cluster metrics in prometheus based dashboards.

We set the cluster label only if we can determine it from the address, otherwise it remains an empty string.

✅ Checks

[x] CI tests (if present) are passing
[x] Adheres to code style for repo
[x] Contributor License Agreement (CLA) completed if not a Reddit employee