Bug:
We get true, false, and null back from the api to represent upvote,
downvote, and no vote respectively. Currently the code is trying to
coerce false to -1. This doesn't work since it actually gets coerced to
So downvotes from the api were not being represented in the ui.
Fix:
Use a switch statement to normalize the api values to 1, 0, and -1. Also
name the validator likes since this is a super specific validator.
Additional changes:
There was an additional potential bug from a recent patch. Since the
api can return falsey values, we don't want to check for falseyness as
a way to determine if we need the fallback value. Although this happens
to work out currently, its ambiguity is probably dangerous.
The fix for this is to check explicitly for undefined since this
implies a missing key. Any other value value means it was explicitly set.
schwers-zz
commented
8 years ago
Bug: We get
true,false, andnullback from the api to represent upvote, downvote, and no vote respectively. Currently the code is trying to coercefalseto -1. This doesn't work since it actually gets coerced toFix: Use a switch statement to normalize the api values to 1, 0, and -1. Also name the validator
likessince this is a super specific validator.Additional changes: There was an additional potential bug from a recent patch. Since the api can return falsey values, we don't want to check for falseyness as a way to determine if we need the fallback value. Although this happens to work out currently, its ambiguity is probably dangerous.
The fix for this is to check explicitly for
undefinedsince this implies a missing key. Any other value value means it was explicitly set.:eyeglasses: @schwers