reddit / rollingpin

fast deploy to lots of servers
https://redditblog.com/2017/06/02/the-evolution-of-code-deploys-at-reddit/
Other
145 stars 33 forks source link

Add Component Report #29

Closed dellis23 closed 7 years ago

dellis23 commented 7 years ago

👓 @spladug @foklepoint

Right now, the component report must be explicitly passed by the operator. I think this makes things a lot cleaner so we don't have to inject the command in and gracefully handle when the deploy script doesn't support component reports. My thinking is that we can look at making this happen every time later on if we find it useful. This also obviates the need to be "smart" about the short format (i.e. don't show output if it looks like only one SHA is running per component), since the operator will have explicitly requested a report. We can still do the smart thing if we make it required, but I want to makes sure it's clear when the component report is failing versus everything being okay (since both would seemingly result in no output under the smart case).

I wasn't sure when I began how to best structure this, since twisted isn't my strong suit, so I put the restructurings into various commits so they can be reverted / changed easily. I'm open to ideas here, or if I'm doing something in a convoluted way, please let me know.

Also open to ideas on how to show the output. Right now it's just a header row with each column separated by tabs. I've included an example in the documentation.

dellis23 commented 7 years ago

:haircut_man: I believe I've addressed everything. There are quite a few new commits, but they should all be pretty small and self-contained.

dellis23 commented 7 years ago

:haircut_man: