reddit / rollingpin

fast deploy to lots of servers
https://redditblog.com/2017/06/02/the-evolution-of-code-deploys-at-reddit/
Other
145 stars 33 forks source link

Skip restart if deploy script reports no code changes #55

Closed eaceaser closed 5 years ago

eaceaser commented 5 years ago

essentially:

I did a little bit of refactoring for this to avoid dumping more conditional logic into deploy.py --

eaceaser commented 5 years ago

:eyeglasses: @spladug @alienth

alienth commented 5 years ago

:running: feel free to re-summon when this is active again.

eaceaser commented 5 years ago

:haircut_woman:

PR necromancer! this is back from the dead.

Since the last PR:

The workaround is to set a boolean on the command to flag if it was explicitly added or not. Currently I'm doing this for custom commands and restart commands. Then, the restart short-circuiting will only filter out commands that were not explicitly added.

I'll refresh the puppet PR separately. I tested this on gangplank, but I still need to do a r2 and mothership test, but I wanted to get this out in front of eyeballs.