Closed eaceaser closed 5 years ago
:eyeglasses: @spladug @alienth
:running: feel free to re-summon when this is active again.
:haircut_woman:
PR necromancer! this is back from the dead.
Since the last PR:
The workaround is to set a boolean on the command to flag if it was explicitly added or not. Currently I'm doing this for custom commands and restart commands. Then, the restart short-circuiting will only filter out commands that were not explicitly added.
I'll refresh the puppet PR separately. I tested this on gangplank, but I still need to do a r2 and mothership test, but I wanted to get this out in front of eyeballs.
essentially:
The deploy stage can now return a dictionary of
Determining whether or not that component is safe to skip a restart for.
If all components have the false bit set, we skip the remaining commands for that host, which will be the restart and wait-for-components commands.
I did a little bit of refactoring for this to avoid dumping more conditional logic into deploy.py --