search

reddmetrics / forma-deploy

Deployer for the FORMA Clojure code.
4 stars 0 forks source link

if no instance type supplied, throw an error instead of launching #5

Closed robinkraft closed 12 years ago

robinkraft commented 12 years ago

I was just bit by this - I mis-specified the instance type (typed --large instead of --type large). I didn't know anything was up until I saw that 25 high memory instances were launching. That's actually ok in this case, but in general I think an error message would be more helpful than a default instance type.

dpetrovics commented 12 years ago

OK ill take care of this, just need to add a validator for --type

On Mon, Jul 23, 2012 at 6:32 PM, Robin Kraft < reply@reply.github.com

wrote:

I was just bit by this - I mis-specified the instance type (typed --large instead of --type large). I didn't know anything was up until I saw that 25 high memory instances were launching. That's actually ok in this case, but in general I think an error message would be more helpful than a default instance type.

Reply to this email directly or view it on GitHub: https://github.com/reddmetrics/forma-deploy/issues/5

robinkraft commented 12 years ago

Great!

sritchie commented 12 years ago

Cool, just need to remove the default.

On Mon, Jul 23, 2012 at 3:32 PM, Robin Kraft < reply@reply.github.com

wrote:

I was just bit by this - I mis-specified the instance type (typed --large instead of --type large). I didn't know anything was up until I saw that 25 high memory instances were launching. That's actually ok in this case, but in general I think an error message would be more helpful than a default instance type.

Reply to this email directly or view it on GitHub: https://github.com/reddmetrics/forma-deploy/issues/5

Sam Ritchie, Twitter Inc 703.662.1337 @sritchie09

(Too brief? Here's why! http://emailcharter.org)