redeclipse / base

Base environment for Red Eclipse and associated source files.
https://redeclipse.net/
431 stars 88 forks source link

ogg files seen as corrupted when read from a zip archive #1407

Closed MirceaKitsune closed 1 year ago

MirceaKitsune commented 1 year ago

I discovered this bug with my music mod, it's now public and can be used to reproduce the issue: https://github.com/redeclipse/base/discussions/1406 I noticed it on Manjaro Linux with RE compiled locally from Git master. While my mod intends to override existing music for a custom soundtrack, I presume this means maps that include a custom track and possibly custom sounds won't work properly either.

It appears that overriding ogg files in zip archives causes them to be seen as corrupted by the engine, they will only work if extracted directly to a directory. To test this download my music mod and place the zip archive inside your RedEclipse user config (eg: /home/username/.redeclipse/version/ for Linux): If you launch RE now you should notice music is no longer playing, if you look in the console it prints an error about the ogg file being corrupted. However if you extract the archive in that directory then remove the zip, the new music works just fine.