[BUGBOT][UI] Misleading Color Choice Labels in Player Setup UI

[discord-bugcrawler[bot]]

[BUGBOT][UI] Misleading Color Choice Labels in Player Setup UI

Description

In the player setup UI of Red Eclipse, the color choices labeled 'Primary' and 'Secondary' are misleading. The 'Primary' option controls the accent color, while the 'Secondary' option controls the base color, which is contrary to what players might expect.

Workarounds

N/A

Information

• Operating system: N/A
• Hardware and drivers: N/A
• Product version: N/A

[qreeves]

Probably easiest to switch playerundertone and playerovertone around, which I had considered when adding it but it would not maintain backward compatibility with the old colours, whether that's really an issue when people need to pick another colour now is the question.

[q009]

Addressed by altering the UI itself https://github.com/redeclipse/base/commit/f42d5f0802df4ce8dddd726cad9f203218385981