search

redfin / react-server

:rocket: Blazing fast page load and seamless navigation.
https://react-server.io/
Apache License 2.0
3.89k stars 184 forks source link

Support dash-delimited options in `.reactserverrc` #783

Open gigabo opened 7 years ago

gigabo commented 7 years ago

The CLI supports options both --camelCase and --dash-delimited.

The .reactserverrc config file only supports camelCase keys.

We should make the config file support both also to eliminate frustrating behavior.

markthethomas commented 7 years ago

@gigabo I can take this on if it's still a thing, looking to help out where I can w/ the project 👍

gigabo commented 7 years ago

@markthethomas Awesome! This will make the UI more consistent / less confusing. Thanks for taking it on!

markthethomas commented 7 years ago

👍💯 On Mon, Jan 9, 2017 at 2:08 PM Bo Borgerson notifications@github.com wrote:

@markthethomas https://github.com/markthethomas Awesome! This will make the UI more consistent / less confusing. Thanks for taking it on!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/redfin/react-server/issues/783#issuecomment-271423289, or mute the thread https://github.com/notifications/unsubscribe-auth/AEstAZWL4S5BXdKbe-DKFPwOp7QX7Lbmks5rQq_kgaJpZM4LEwFQ .

-- Mark Thomas

@markthethomas everywhere ifelse.io

markthethomas commented 7 years ago

@gigabo I'd also be interested in helping clear up some of the docs and/or helping w/ the component API documentation, there are a few things I've run into when integrating this w/ my projects that I've yet to overcome all the way 👍 think I saw a few other issues where this came up

markthethomas commented 7 years ago

@gigabo is there any general objection to bringing in deps to address things like this? was thinking of decamelize, which I think yargs already depends on and uses to address this case. jw before I commit and PR anything 👍

doug-wade commented 7 years ago

Generally, we're trying to head in the opposite direction, per #277. If, however, decamelize is already in our dependency closure, and yargs doesn't have a way to support this natively, then I don't see any harm.

markthethomas commented 7 years ago

Sounds good, thanks! On Wed, Jan 11, 2017 at 4:07 PM Douglas Wade notifications@github.com wrote:

Generally, we're trying to head in the opposite direction, per #277 https://github.com/redfin/react-server/issues/277. If, however, decamelize is already in our dependency closure, and yargs doesn't have a way to support this natively, then I don't see any harm.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/redfin/react-server/issues/783#issuecomment-272036119, or mute the thread https://github.com/notifications/unsubscribe-auth/AEstAZgnal7c7cwnP_gk2hpvDwVX7Ipcks5rRW7MgaJpZM4LEwFQ .

-- Mark Thomas

@markthethomas everywhere ifelse.io

drewpc commented 7 years ago

Sorry for closing, I didn't realize this was moving to camelCase and dash-delimited for both sets of configs. Open again!

mlolson commented 7 years ago

@markthethomas Any update on this? Mind if I take it?

markthethomas commented 7 years ago

Shoot, this totally got away from me - go ahead 👍 On Thu, Jun 15, 2017 at 3:57 PM Matt Olson notifications@github.com wrote:

@markthethomas https://github.com/markthethomas Any update on this? Mind if I take it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/redfin/react-server/issues/783#issuecomment-308885150, or mute the thread https://github.com/notifications/unsubscribe-auth/AEstATzVURvgbxleT3XaE1dUhzMcIpEdks5sEbMWgaJpZM4LEwFQ .

-- Mark Thomas

@markthethomas everywhere ifelse.io