Rename __clientTemp and separate client and server build

redfin / react-server

:rocket: Blazing fast page load and seamless navigation.

https://react-server.io/

Apache License 2.0

3.89k stars 184 forks source link

Rename __clientTemp and separate client and server build #799

Open jhnns opened 7 years ago

jhnns commented 7 years ago

Following up #794

Currently, all webpack output is located under __clientTemp. To me, this is confusing because the folder does not only contain client stuff, it's also not temporary. It's the actual build artifact that people will deploy.

I would recommend to rename __clientTemp to build or dist (we can bikeshed about that :wink:) which contains two folders, client and server.

doug-wade commented 7 years ago

I dig it. If I understand https://github.com/redfin/react-server/pull/791 correctly, __clientTemp is a particularly bad name, since it will also be the server temp directory. I'm leaning towards build, personally, though either strikes me as an improvement.

breezewish commented 7 years ago

Could you also make it configurable? Currently we have deployment phase and dev phase. Currently they use the same directory and affect each other.