search

redfin / react-server

:rocket: Blazing fast page load and seamless navigation.
https://react-server.io/
Apache License 2.0
3.89k stars 184 forks source link

Make ClientRequest chop off fragment identifiers from urls #972

Closed jleoirab closed 6 years ago

jleoirab commented 6 years ago

This PR tries to make ClientRequest and ExpressServerRequest consistent by ensuring the that fragment identifiers are chopped of from urls in ClientRequest and that they are not included when getUrl is called.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

gigabo commented 6 years ago

This looks good to me with the latest changes. Nice fix @j-beatzz.