add missing dependencies to react-server-cli

redfin / react-server

:rocket: Blazing fast page load and seamless navigation.

https://react-server.io/

Apache License 2.0

3.89k stars 184 forks source link

add missing dependencies to react-server-cli #983

Closed mcskinner closed 6 years ago

mcskinner commented 6 years ago

This is intended to fix #971, which can be patched manually via global install of the missing packages. Of course my local environment is now tainted by the global dependency installs, so I'm not entirely sure how I should go about testing this (advice appreciated).

The dependency versions are copied over from react-server, but I know next to nothing about package versioning best practices. I'm willing to be scolded and then corrected for choosing poorly.

hatfarm commented 6 years ago

I also had to add serialize-javascript to get it to start up.

mcskinner commented 6 years ago

guess this project is on low maintenance mode...

roblg commented 6 years ago

Thanks @mcskinner! Sorry for the slow turnaround.

@hatfarm if you have a repro for what you're seeing, can you file a separate issue? I verified that these changes fix the issue described in #971, so yours might be slightly different

mcskinner commented 6 years ago

@roblg no problem, sorry for the snark haha :)