search

redgeoff / delta-pouch

Conflict-free collaborative editing for PouchDB
196 stars 13 forks source link

Add a dist file #10

Closed nolanlawson closed 10 years ago

nolanlawson commented 10 years ago

Forgot to mention in the plugin-seed readme, but to add the dist/ files to npm so other people can use it when they npm install, just do:

npm run build
git add -f dist/*

then commit, then npm publish.

redgeoff commented 10 years ago

I intentionally added dist to .gitignore as I was thinking that the build files should not be in the repo. That's why README.md mentions to run npm run build before running npm run dev-server. I see your point about not having the files in dist for npm though, which is definitely a problem. Is adding dist to the git repo really the best way to handle this or is there a cleaner way?

nolanlawson commented 10 years ago

I know how you feel, but I have just resigned myself to checking in these files to git. People look for them in GitHub anyway.

dandoen commented 10 years ago

+1 on having the build in the repo. Even if only to reference to certain lines when having an issue :)

PS. would this be something you @nolanlawson / @redgeoff would be able to help out with: http://stackoverflow.com/questions/25330428/partial-update-of-pouchdb-document-with-the-delta-pouch-plugin-using-angularjs

nolanlawson commented 10 years ago

I don't see how that error is possible. Promise is supposed to be shimmed.

nolanlawson commented 10 years ago

@dandoen Wait for @redgeoff to do an official build, because it looks like somehow Promises are not being set up correctly, and I don't understand how if I can't see the exact script that you're using.

redgeoff commented 10 years ago

@dandoen I've already started working on an angular adapter for delta-pouch that should make working with delta-pouch super easy! I'm hoping to have it released in the next week or so after I iron out a few more issues with delta-pouch!