redgeoff / mson-react

React and Material-UI Rendering Layer for MSON
Apache License 2.0
80 stars 13 forks source link

An in-range update of react-beautiful-dnd is breaking the build 🚨 #90

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The dependency react-beautiful-dnd was updated from 10.0.4 to 10.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

react-beautiful-dnd is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **ci/circleci: build:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/redgeoff/mson-react/350?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).

Release Notes for 10.1.0

beautiful-by-jake-small

🎧🎢 Release notes designed to be listed to with: "Once there were dragons" @ 4:05

Highlights πŸ€Ύβ€β™€οΈ

  • πŸ‘©β€πŸŽ¨ Stunning animation improvements
  • πŸ“– Overhauled documentation
  • πŸ“± More predictable touch dragging
  • 🏠 Simplified home list styling
  • πŸ’… New project design
  • πŸ“ Blogs of our learnings

Beautiful πŸ”

This release pushes react-beautiful-dnd to new summits of interaction design.

We have removed instant movement (snapping) when moving between lists. Snapping breaks the visual language of moving physical objects around that react-beautiful-dnd is trying to emulate.

βœ… No snapping when moving between lists

refreshed-example-2

❌ This is what it used to be (snapping in the 🏠 home list after a drop)

slow-snapping

You do not need to do anything to get the new animation pattern. I have marked this change as a feature release as it is new design behaviour.

Blog: Beautiful interactions πŸ“

There was a huge amount of work to remove snapping when moving between lists. Who would have thought? Not me πŸ₯΅. I wrote a blog which goes over the journey of this feature in depth. Personally, I think it well worth your time!

πŸ“Blog β†’ Beautiful interactions: Crafting elegant and robust drag and drop animations

New logo πŸ‘©β€πŸŽ¨

logo-migration

We have moved to a logo that encapsulates the playfulness and delight that we are striving for with react-beautiful-dnd

Blog: Logo creation πŸ“

Maryanne Nguyen, a very talented designer at Atlassian, has detailed her creative process in creating the new react-beautiful-dnd logo in a blog 🎨

πŸ“Blog β†’ maryannemade: react-beautiful-dnd logo

More predictable touch dragging πŸ“±

react-beautiful-dnd tries to respect standard browser interactions as much as possible. Currently, the library plays well with force touch interactions:

If the user force presses on the element before they have moved the element (even if a drag has already started) then the drag is cancelled and the standard force press action occurs. For an anchor, this is a website preview.

Unfortunately, heavy presses can cancel a drag. It can be tricky at times to get the right amount of pressure to correctly use touch dragging. This can be frustrating for users.

We have added an option for you to opt-out of respecting force touch interactions. This option will disable force press interactions on the drag handle. However, it allows for a more consistent touch dragging interaction.

We have added shouldRespectForceTouch as a prop to <Draggable />. It defaults to true in order to respect force touch interactions, but you can set it to false to opt out of respecting force touch

<Draggable
  draggableId="draggable"
+ shouldRespectForceTouch={false}
>

</Draggable>

This change resulted in a feature release. The default behaviour matches the behaviour of previous versions.

Should force touch be respected by default?

Right now shouldRespectForceTouch defaults to true in order to respect browser interactions. However, for this specific use case, I am thinking that the default could be to not respect force touch in order to have a more consistent touch dragging experience out of the box.

I have created a request for discussion to collect other people's thoughts on what the default should be.

Simplified home list styling 🏠

We have added a new value to the DroppableStateSnapshot: draggingFromThisWith

type DroppableStateSnapshot = {|
  isDraggingOver: boolean,
  draggingOverWith: ?DraggableId,
+ draggingFromThisWith: ?DraggableId,
|};

draggingFromThisWith is populated with the draggableId of the dragging item in the 🏠 home list for the entire drag. This allows you to style the home list differently from the other lists if you like. We recommend you do this to make it clear which list the user is dragging from. You can read more about the thinking behind this in my blog

In this example we set the background-color of the home list to pink when we are dragging over the list. We set the background-color of the home list to blue when not dragging over the home list.

no-placeholder-when-over-no-list

Overhauled documentation πŸ“–

We have totally overhauled our documentation to be easier to find and use information.

Our README.md was getting too big. It was hard for new comers to know where to start, and it was hard for consumers of the library to quickly find information. We have simplified our README.md and added a comprehensive documentation section which links off to categories of information.

The README.md now contains a high-level introduction to the project, feature set, how to get started and then links to the rest of the documentation.

For new comers and evaluators πŸ‘Ά

Information in the README.md:

  • Big gif showing off what the library is about
  • Reduced badges to the critical subset to reduce noise
  • High level motivation of the project
  • Feature set and limitations
  • Getting started guide
  • An About section which links off information useful to understand, evaluate and get started with the library.

For consumers πŸ‘©β€πŸŽ€

  • The documentation has been broken down into more logical independent chunks to make it clearer where to find topical information. Previously API was under a wall of design thinking information which would not be useful to a non-evaluator
  • All documentation pages have a link back to the documentation root for quickly jumping around

Documentation engineering health πŸ‘¨β€βš•οΈ

  • Added a test to ensure that there are no more broken links πŸŽ‰. This is by far the cause of the most issues
  • Added test to ensure consistent usage of component names
  • Added test to ensure all documentation pages end with a backlink to the documentation root

Refreshed examples πŸ¦Έβ€β™‚οΈ #1096

We have made our examples brighter and more colourful

Previous New style
old style new style

We have also upgraded to Storybook v5 and added our new logo to the header

new style

Other improvements

  • Only attaching to the redux devtools when process.env.NODE_ENV === 'development' #1085. Thanks @teleaziz!!
  • More collision engine refinements

Fixes πŸ›

  • A transition for a property other than transform that finished during a drop animation on a Draggable could cause the drop to end suddenly #1096
  • position:fixed lists on ie11 #1091 #1088. Thanks @InvisibleBacon for raising this one
  • Typo in docs #1102. Thanks @jDeppen

Engineering health

  • Upgraded to flow 0.94 #1119
  • Upgrade of all dev dependencies #1119
  • Moved example website to use emotion πŸ‘©β€πŸŽ€ #1128
  • Moving browser tests to cypress.io. Also added a few more browser tests #1122

cypress

Commits

The new version differs by 14 commits.

  • 45cc88a v10.1.0
  • 67b96c8 Merging dev to master (it's happening) (#1158)
  • 1c1f42e Fix broken example source link (#1121)
  • c782b2a Fix dead link in README.md (#1106)
  • dedd3c9 Fix typo (#1102)
  • 4518e53 Ie 11 window scroll fix (#1091)
  • 2e93958 adding options to storybook setup (#1087)
  • adc5a2e compose with redux dev tools in development mode only (#1085)
  • fc61e8a More storybook popping (#1083)
  • 5fb1532 pop out button (#1082)
  • fa03b1f adding iframe pop decorator (#1081)
  • 65770cc Join the community on Spectrum! (#1080)
  • a7438c1 goodbye for now (#1076)
  • d6be548 adding nvmrc (#1077)

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 10.0.4 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

redgeoff commented 5 years ago

Replaced by https://github.com/redgeoff/mson-react/pull/93