Closed pkkm closed 3 years ago
Ok, could you rebase on master branch and squash the commit into one commit?
OK!
thanks
Windows 10 users don't need set up tar location since tar is already part of system, right? I don't have Windows 10 right now.
I don't have it either, but this official article says that Windows ships with BSD tar starting with an Insider Build from December 2017. So yes, I think that everyone who uses Windows 10 from 2018 or later should have it.
Thanks for creating this useful package, by the way!
This is my proposed minor redesign of
elpa-mirror
with the goal to:tar
orcygpath
in an unusual place.bsdtar
on Linux.The changes can be summarized as:
defcustom
s,elpamr-tar-executable
andelpamr-cygpath-executable
. This will force Windows users who havetar
andcygpath
inC:\cygwin64\bin
or a similar location to add two lines to theirinit.el
that they didn't need before. However, I still think this is overall the better solution, for two reasons. First, it letselpa-mirror
be used by people who havetar
in an unusual location likeC:\Program Files (x86)\MSYS2\usr\bin
or/home/pkkm/.bin
. Second, that's what users probably expect from other packages—for example, Magit uses amagit-git-executable
variable.elpamr-create-mirror-for-installed
.Most of the changes also happen to improve performance. Here is the time it takes to recreate my repo at various commits, average of 100 runs:
master
So this PR more than doubles the performance of
elpa-mirror
on my machine.