redguardtoo / elpa-mirror

Create local emacs package repository. 15 seconds to install 115 packages.
312 stars 54 forks source link

Generalize the handling of paths and BSD tar #31

Closed pkkm closed 3 years ago

pkkm commented 3 years ago

This is my proposed minor redesign of elpa-mirror with the goal to:

The changes can be summarized as:

Most of the changes also happen to improve performance. Here is the time it takes to recreate my repo at various commits, average of 100 runs:

Commit Time (s)
master 1.74
Remove unnecessary shell usage in elpamr--is-mac 1.09
Separate the check for BSD tar and the check for macOS 0.90
Check for BSD tar only once per run 0.62

So this PR more than doubles the performance of elpa-mirror on my machine.

redguardtoo commented 3 years ago

Ok, could you rebase on master branch and squash the commit into one commit?

pkkm commented 3 years ago

OK!

redguardtoo commented 3 years ago

thanks

redguardtoo commented 3 years ago

Windows 10 users don't need set up tar location since tar is already part of system, right? I don't have Windows 10 right now.

pkkm commented 3 years ago

I don't have it either, but this official article says that Windows ships with BSD tar starting with an Insider Build from December 2017. So yes, I think that everyone who uses Windows 10 from 2018 or later should have it.

pkkm commented 3 years ago

Thanks for creating this useful package, by the way!