redguardtoo / js-comint

js-comint will send the code from Emacs into node.js or rhino
GNU General Public License v3.0
71 stars 22 forks source link

Add support for nvm to js-comint #4

Closed stefano-m closed 8 years ago

stefano-m commented 8 years ago

Hi @redguardtoo, I have recently discussed with @rejeep in nvm.el issue #6 the possibility to use nvm and node in a comint mode.

We think that the best place where this should go is js-comint, so I here is a PR to integrate nvm.

There is a breaking change in which the js interpreter command and arguments are now customized with 2 variables (this is in the documentation). I think that this change makes the code easier to read and think about (e.g. no more string splitting and assumptions about what is the executable and what are the arguments).

I understand that this repo is supposed hold js-comint in maintenance mode only. But since the de-facto JS interpreter is now the node REPL, it's very useful to be able to run code against multiple versions.

Thank you for considering this PR.