search

redguardtoo / wucuo

Fastest solution to spell check camel case code or plain text
122 stars 4 forks source link

Missing autoloads #15

Closed lafrenierejm closed 3 years ago

lafrenierejm commented 4 years ago

When packaging 0.2.7 for GNU Guix, I the following warning when byte-compiling wucuo.el:

In end of data:
wucuo.el:662:1:Warning: the following functions are not known to be defined:
    wucuo-flyspell-html-verify, wucuo-flyspell-org-verify,
    markdown-flyspell-check-word-p,
    wucuo-flyspell-highlight-incorrect-region-hack

I believe this is all a matter of missing autoload declarations.

redguardtoo commented 4 years ago

cd8b0eb some autoload warning fix (Chen Bin)

Not sure it's fixed or not. Actually byte compiling is fine on my side.

lafrenierejm commented 4 years ago

0.2.8 appears to have resolved the warning for wucuo-flyspell-highlight-incorrect-region-hack, but I'm still getting warnings for the other functions:

wucuo.el:775:1:Warning: the following functions are not known to be defined:
    wucuo-flyspell-html-verify, wucuo-flyspell-org-verify,
    markdown-flyspell-check-word-p
lafrenierejm commented 4 years ago

Looking at wucuo-flyspell-html-verify, I see that

  1. The function is defined in wucuo-flyspell-html-verify.el.
  2. The function is referenced in wucuo.el.
  3. wucuo.el never requires wucuo-flyspell-html-verify.
lafrenierejm commented 4 years ago

https://github.com/lafrenierejm/wucuo/commit/ef9801d7e77f8404642cacad88f3c5d162646dd4 resolved the issue for wucuo-flyspell-html-verify and wucuo-flyspell-org-verify. The warning is still present for markdown-flyspell-check-word-p; I need to take a closer look through the code before I'll have a suggestion for that function.

lafrenierejm commented 4 years ago

I have updated the branch https://github.com/lafrenierejm/wucuo/tree/bytecompile-warning. With the current HEAD (89b99166768afb811c48a7db7c93c02d51a32b09), all of the autoload warnings are resolved.

redguardtoo commented 4 years ago

I try to avoid require for performance reason. Let me figure out a solution

lafrenierejm commented 3 years ago

Everything looked good when packaging 0.2.9, so I'll close this. Thanks for the package!