redhat-actions / buildah-build

GitHub Action to use 'buildah' to build a container image.
https://github.com/marketplace/actions/buildah-build
MIT License
137 stars 35 forks source link

improve documentation for multi-architecture builds #59

Closed agterdenbos closed 3 years ago

agterdenbos commented 3 years ago

Description

Some documentation improvements for self-hosted runners on non-amd64 architectures:

  1. Adds docker.io registry prefix to the qemu-user-static registration command
  2. Replaces amd64 by None (host architecture)
  3. Replace the multiarch/qemu-user-static image by docker.io/tonistiigi/binfmt to support container hosts other than amd64
  4. Removes the reference to Multi arch builds in the Inputs for build without dockerfile section. Adds description that qemu-user-static is only needed for RUN instructions in dockerfiles.
  5. Adds a note that the qemu-user-static registration remains active until the container host reboots.

Related Issue(s)

58

Checklist

Changes made

tetchel commented 3 years ago

apologies @agterdenbos, could you sign your commits? https://docs.github.com/en/github/authenticating-to-github/managing-commit-signature-verification/signing-commits

image

agterdenbos commented 3 years ago

apologies @agterdenbos, could you sign your commits? https://docs.github.com/en/github/authenticating-to-github/managing-commit-signature-verification/signing-commits

image

I signed them now

divyansh42 commented 3 years ago

I've released v2.5.2 and rolled forward v2.

Thank you for this contribution! :slightly_smiling_face: