Refactor inputs to support docker/metadata-action - Githubissues

redhat-actions / buildah-build

GitHub Action to use 'buildah' to build a container image.

https://github.com/marketplace/actions/buildah-build

MIT License

137 stars 35 forks source link

Refactor inputs to support docker/metadata-action #76

Closed ntkme closed 2 years ago

ntkme commented 2 years ago

This PR adds support for docker/metadata-action@v2. See #74.

Description

Support tags input in full image name form. When full image name form is used, input image would be optional.

Related Issue(s)

Closes #74

Checklist

[x] This PR includes a documentation change
[ ] This PR does not need a documentation change
[x] This PR includes test changes
[ ] This PR's changes are already tested
[ ] This change is not user-facing
[ ] This change is a patch change
[x] This change is a minor change
[ ] This change is a major (breaking) change

Changes made

Input image is now declared as required: false, and checked during runtime.
If all tags are in full image name form, the tags are used as is.
tags input are split by /\s+/ instead of " " because docker/metadata-action's output is newline separated.

divyansh42 commented 2 years ago

Do you want to update/improve the documentation to clearly explain the changes? (In the same way, suggested at https://github.com/redhat-actions/push-to-registry/pull/50#issuecomment-937981210)

ntkme commented 2 years ago

@tetchel Done with refactoring and added documentation. PTAL. Thanks!

tetchel commented 2 years ago

lgtm, i'm going to hold this until the PTR one is approved too and then we can merge both and make sure they make sense together.