search

redhat-actions / buildah-build

GitHub Action to use 'buildah' to build a container image.
https://github.com/marketplace/actions/buildah-build
MIT License
137 stars 35 forks source link

[BUG] buildah config fails with error unknow flag --platform #82

Closed divyansh42 closed 2 years ago

divyansh42 commented 2 years ago

In the PR #75 we added support for platform but it seems --platform flag is only available for buildah bud command. Therefore when using --platform with buildah config command it fails with error unknown flag.

Failed workflow: https://github.com/divyansh42/buildah-build/runs/3923850206?check_suite_focus=true#step:11:90

divyansh42 commented 2 years ago

@jayaddison since you authored PR #75. So, I just wanted to ask if you have seen --platform flag in config command in some buildah version or you just did as --arch option was available (So ideally platform option should also be present in buildah config command). I don't see that in buildah config docs.

jayaddison commented 2 years ago

@divyansh42 Sorry, this is my mistake - no, I had not tested that path (I incorrectly thought that --platform was available in both cases).

I'll open a cleanup pull request to clean that up.

divyansh42 commented 2 years ago

Yeah, during the review I also thought that this should be available in both cases. We could have found this earlier if we had added tests in our existing multi-arch workflow. I opened up issue #81 for this.