Closed jayaddison closed 2 years ago
To make it more clear, can we add
this input is not supported for build without containerfile
in action.ymlplatform
input?
We should make this clearer, yep :+1:
Maybe I am picking smalI details, but I wonder if we should flip that around in to a statement about where the parameter is supported: (only supported with containerfile builds)
Maybe I am picking smalI details, but I wonder if we should flip that around in to a statement about where the parameter is supported:
(only supported with containerfile builds)
Sounds better :+1:
To save yourself from these types of errors probably you can add git-commit hooks that are present here.
Sorry, slightly spammy with the commits here, and I realized I forgot to add sign-offs on a few of them. When we are ready I can squash down to a single signed commit.
No problem - apologies for my introducing the problem in the first place!
Description
The
buildah config
command does not currently support theplatform
parameter.75 introduced support for
platform
in both build-from-containerfile (which usesbuildah bud
) and build-without-containerfile (which usesbuildah config
).This pull request removes support for
platform
during builds-without-containerfile, and raises an error if the user attempts that.Related Issue(s)
Resolves #82.
Checklist
[ ] This PR does not need a documentation change
[ ] This PR's changes are already tested
Changes made
platform
parameter during build-without-containerfile