redhat-actions / buildah-build

GitHub Action to use 'buildah' to build a container image.
https://github.com/marketplace/actions/buildah-build
MIT License
137 stars 35 forks source link

Fix: platform parameter is not supported by buildah config (build-without-containerfile) #83

Closed jayaddison closed 2 years ago

jayaddison commented 2 years ago

Description

The buildah config command does not currently support the platform parameter.

75 introduced support for platform in both build-from-containerfile (which uses buildah bud) and build-without-containerfile (which uses buildah config).

This pull request removes support for platform during builds-without-containerfile, and raises an error if the user attempts that.

Related Issue(s)

Resolves #82.

Checklist

Changes made

jayaddison commented 2 years ago

To make it more clear, can we add this input is not supported for build without containerfile in action.yml platform input?

We should make this clearer, yep :+1:

Maybe I am picking smalI details, but I wonder if we should flip that around in to a statement about where the parameter is supported: (only supported with containerfile builds)

divyansh42 commented 2 years ago

Maybe I am picking smalI details, but I wonder if we should flip that around in to a statement about where the parameter is supported: (only supported with containerfile builds)

Sounds better :+1:

divyansh42 commented 2 years ago

To save yourself from these types of errors probably you can add git-commit hooks that are present here.

jayaddison commented 2 years ago

Sorry, slightly spammy with the commits here, and I realized I forgot to add sign-offs on a few of them. When we are ready I can squash down to a single signed commit.

jayaddison commented 2 years ago

No problem - apologies for my introducing the problem in the first place!